bpo-42199: Fix bytecode_helper assertNotInBytecode #23031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
force-pushed
the
mb-fix-bytecode-helper
branch
from
2641bf3
to
58a04cf
Compare
|
This patch contributed by @DinoV. |
|
|
|
It turns out that git is pretty good at this kind of thing and cherry-picking really does work. So maybe the automated tooling will do just fine... |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
DinoV
approved these changes
Dec 18, 2020
|
@DinoV: Please replace |
|
time to backport? :D |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
* bpo-42199: Fix bytecode_helper assertNotInBytecode Add tests. *📜 🤖 Added by blurb_it. Co-authored-by: Dino Viehland <dinoviehland@fb.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ensure that the helper will only fail if the programmer provided an
argand it matches an instructionarg. Add tests.https://bugs.python.org/issue42199