Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42199: Fix bytecode_helper assertNotInBytecode #23031

merged 2 commits into from Dec 18, 2020


Copy link

@tekknolagi tekknolagi commented Oct 29, 2020

Ensure that the helper will only fail if the programmer provided an arg and it matches an instruction arg. Add tests.

Copy link
Contributor Author

This patch contributed by @DinoV.

Copy link
Contributor Author moved from tests/ to tests/support/ at some point, so backporting this may not be as easy as cherry-picking.

Copy link
Contributor Author

It turns out that git is pretty good at this kind of thing and cherry-picking really does work. So maybe the automated tooling will do just fine...

Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
DinoV approved these changes Dec 18, 2020
@DinoV DinoV merged commit 6e799be into python:master Dec 18, 2020
3 checks passed
Copy link

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor Author

time to backport? :D

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
* bpo-42199: Fix bytecode_helper assertNotInBytecode

Add tests.

* 📜🤖 Added by blurb_it.

Co-authored-by: Dino Viehland <>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
stale Stale PR or inactive for long period of time.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants