Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 (GH-23556) #23622

Merged
merged 1 commit into from Dec 3, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 3, 2020

macOS releases numbering has changed as of macOS 11 Big Sur. Previously, major releases were of the form 10.x, 10.x+1, 10.x+2, etc; as of Big Sur, they are now x, x+1, etc, so, for example, 10.15, 10.15.1, ..., 10.15.7, 11, 11.0.1, 11.1, ..., 12, 12.1, etc. Allow Python to build with single-digit deployment target values. Patch provided by FX Coudert.
(cherry picked from commit 5291639)

Co-authored-by: FX Coudert fxcoudert@gmail.com

https://bugs.python.org/issue42504

Automerge-Triggered-By: GH:ned-deily

macOS releases numbering has changed as of macOS 11 Big Sur.  Previously, major releases were of the form 10.x, 10.x+1, 10.x+2, etc; as of Big Sur, they are now x, x+1, etc, so, for example, 10.15, 10.15.1, ..., 10.15.7, 11, 11.0.1, 11.1, ..., 12, 12.1, etc. Allow Python to build with single-digit deployment target values. Patch provided by FX Coudert.
(cherry picked from commit 5291639)

Co-authored-by: FX Coudert <fxcoudert@gmail.com>
@miss-islington
Copy link
Contributor Author

@fxcoudert and @ned-deily: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@fxcoudert and @ned-deily: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 09a698b into python:3.9 Dec 3, 2020
@miss-islington miss-islington deleted the backport-5291639-3.9 branch December 3, 2020 03:43
@gueano
Copy link

gueano commented Dec 8, 2020

I think this is a bug of brew formula (python@3.8, python@3.9), my MacBook os version is 11.0.1, upgraded before yesterday.

python3.8 and python3.9 all failed to build because of this bug.

I found this Homebrew/homebrew-core@bce1be3 today morning, and it works for me.

I just modified "MACOSX_DEPLOYMENT_TARGET=#{MacOS.version}" to "MACOSX_DEPLOYMENT_TARGET=11.0.1" in the formula, python building just all good.

Wish this helps.

@fxcoudert
Copy link
Contributor

Could this be backported to the 3.8 branch? The failure still exists there, in the 3.8.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants