Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42727: [Enum] EnumMeta.__prepare__ now accepts **kwds #23917

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Dec 24, 2020

@bedevere-bot
Copy link

@ethanfurman: Please replace # with GH- in the commit message next time. Thanks!

ethanfurman added a commit that referenced this pull request Dec 24, 2020
@ethanfurman ethanfurman added the needs backport to 3.9 only security fixes label Dec 24, 2020
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6ec0adefad60ec7cdec61c44baecf1dccc1461ab 3.9

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Dec 24, 2020
(cherry picked from commit 6ec0ade)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 24, 2020
@bedevere-bot
Copy link

GH-23926 is a backport of this pull request to the 3.9 branch.

ethanfurman added a commit that referenced this pull request Dec 24, 2020
…3917). (GH-23926)

* [3.9] [Enum] EnumMeta.__prepare__ now accepts **kwds (GH-23917).
(cherry picked from commit 6ec0ade)
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.9 has failed when building commit f7dca9b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/535/builds/239) and take a look at the build logs.
  4. Check if the failure is related to this commit (f7dca9b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/535/builds/239

Failed tests:

  • test_asyncio

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 1        
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 11 (delta 5), reused 5 (delta 5), pack-reused 1        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Reset branch '3.9'

test_tix skipped -- No module named '_tkinter'
test_winreg skipped -- No module named 'winreg'
test_winsound skipped -- No module named 'winsound'
test_tk skipped -- No module named '_tkinter'
test_sqlite skipped -- No module named '_sqlite3'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_tcl skipped -- No module named '_tkinter'
test_msilib skipped -- No module named '_msi'
test_devpoll skipped -- test works only on Solaris OS family
test_winconsoleio skipped -- test only relevant on win32
test_ioctl skipped -- Unable to open /dev/tty
test_ttk_guionly skipped -- No module named '_tkinter'
test_idle skipped -- No module named '_tkinter'
test_ttk_textonly skipped -- No module named '_tkinter'
test_kqueue skipped -- test works only on BSD
<string>:2: PendingDeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/os.py'> has no attribute 'startfile'
test_turtle skipped -- No module named '_tkinter'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_readline skipped -- No module named 'readline'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.437s

OK (skipped=2)
Timeout (0:15:00)!
Thread 0x000003ff90b79710 (most recent call first):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/selectors.py", line 469 in select
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 1854 in _run_once
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 596 in run_forever
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 629 in run_until_complete
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/test_asyncio/test_subprocess.py", line 189 in test_terminate
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 593 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 653 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/support/__init__.py", line 1796 in _run_suite
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/support/__init__.py", line 1918 in run_unittest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 209 in _test_module
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 234 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 270 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 140 in _runtest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 193 in runtest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest_mp.py", line 80 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 658 in _main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 638 in main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 716 in main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/runpy.py", line 197 in _run_module_as_main
Timeout (0:15:00)!
Thread 0x000003ff869f9710 (most recent call first):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/selectors.py", line 469 in select
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 1854 in _run_once
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 596 in run_forever
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/asyncio/base_events.py", line 629 in run_until_complete
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/test_asyncio/test_subprocess.py", line 176 in test_kill
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 593 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/case.py", line 653 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/support/__init__.py", line 1796 in _run_suite
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/support/__init__.py", line 1918 in run_unittest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 209 in _test_module
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 234 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 270 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 153 in _runtest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/runtest.py", line 193 in runtest
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 318 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 695 in _main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 638 in main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/libregrtest/main.py", line 716 in main
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [buildbottest] Error 1

Cannot open file '/home/dje/cpython-buildarea/3.9.edelsohn-sles-z/build/test-results.xml' for upload

@gpshead
Copy link
Member

gpshead commented Dec 25, 2020

#23932 should fix the CI failure on the docs

gpshead added a commit that referenced this pull request Dec 25, 2020
It was causing CI failures.  the offending file came from #23917

```
python3 tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:1: default role used
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:2: default role used
2 problems with severity 2 found.
Makefile:204: recipe for target 'check' failed
```
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2020
It was causing CI failures.  the offending file came from python#23917

```
python3 tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:1: default role used
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:2: default role used
2 problems with severity 2 found.
Makefile:204: recipe for target 'check' failed
```
(cherry picked from commit 8badade)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Dec 25, 2020
It was causing CI failures.  the offending file came from #23917

```
python3 tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:1: default role used
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:2: default role used
2 problems with severity 2 found.
Makefile:204: recipe for target 'check' failed
```
(cherry picked from commit 8badade)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
It was causing CI failures.  the offending file came from python#23917

```
python3 tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:1: default role used
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:2: default role used
2 problems with severity 2 found.
Makefile:204: recipe for target 'check' failed
```
@ethanfurman ethanfurman deleted the enum-prepare_kwds branch April 15, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants