Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43353: Document that logging.getLevelName() accepts string representation of logging level. #24693

Merged
merged 1 commit into from Mar 8, 2021

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Mar 1, 2021

bpo-43353

https://bugs.python.org/issue43353

Automerge-Triggered-By: GH:vsajip

Lib/logging/__init__.py Outdated Show resolved Hide resolved
Doc/library/logging.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@felixxm
Copy link
Contributor Author

felixxm commented Mar 7, 2021

@vsajip Thanks for the review 👍

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

@felixxm: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@felixxm felixxm deleted the fix-issue-43353 branch March 8, 2021 11:17
felixxm added a commit to felixxm/cpython that referenced this pull request Mar 11, 2021
…entation of logging level. (pythonGH-24693)

(cherry picked from commit bbba282)

Automerge-Triggered-By: GH:vsajip
felixxm added a commit to felixxm/cpython that referenced this pull request Mar 11, 2021
…entation of logging level. (pythonGH-24693)

(cherry picked from commit bbba282)

Automerge-Triggered-By: GH:vsajip
miss-islington pushed a commit that referenced this pull request Mar 12, 2021
…representation of logging level. (GH-24693) (GH-24826)

(cherry picked from commit bbba282)

Automerge-Triggered-By: GH:vsajip
freddrake pushed a commit that referenced this pull request Mar 17, 2021
…entation of logging level. (GH-24693) (#24825)

(cherry picked from commit bbba282)

Automerge-Triggered-By: GH:vsajip
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
…entation of logging level. (pythonGH-24693)

[bpo-43353]()

Automerge-Triggered-By: GH:vsajip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants