Skip to content

[3.9] bpo-41832, bpo-42083: PyType_FromModuleAndSpec() can accept the NULL tp_doc slot (GH-25687) #25852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 3, 2021

(cherry picked from commit 88c2cfd)

Co-authored-by: Hai Shi shihai1992@gmail.com

https://bugs.python.org/issue41832

@Fidget-Spinner Fidget-Spinner changed the title bpo-41832, bpo-42083: PyType_FromModuleAndSpec() can accept the NULL tp_doc slot (GH-25687) [3.9] bpo-41832, bpo-42083: PyType_FromModuleAndSpec() can accept the NULL tp_doc slot (GH-25687) May 3, 2021
@Fidget-Spinner
Copy link
Member Author

Cross reference to https://bugs.python.org/issue42083. Should I add the tests suggested by steve on the bpo? (and if so, do I add them to master branch too before backporting to 3.9?)

@ambv
Copy link
Contributor

ambv commented May 4, 2021

@Fidget-Spinner, yes please, add tests to the master branch first, then backport.

@Fidget-Spinner
Copy link
Member Author

@Fidget-Spinner Fidget-Spinner deleted the backport-88c2cfd9ffb branch May 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants