New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bpo-30822: Fix testing of datetime module." #2588

Merged
merged 15 commits into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@vstinner
Member

vstinner commented Jul 5, 2017

vstinner added some commits Jul 5, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 5, 2017

@haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalkin, @birkenfeld and @serhiy-storchaka to be potential reviewers.

mention-bot commented Jul 5, 2017

@haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalkin, @birkenfeld and @serhiy-storchaka to be potential reviewers.

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jul 5, 2017

Member

I propose to revert the change because test_datetime now takes up to 20 minutes, which causes random failures, especially on the slow "ARMv7 Ubuntu 3.x" buildbot:
http://bugs.python.org/issue30822#msg297734

This revert is part of the new policy to keep buildbots green:
https://mail.python.org/pipermail/python-committers/2017-June/004588.html

The revert is just a solution to get more time to fix a proper fix, before reapply the commit.

Member

vstinner commented Jul 5, 2017

I propose to revert the change because test_datetime now takes up to 20 minutes, which causes random failures, especially on the slow "ARMv7 Ubuntu 3.x" buildbot:
http://bugs.python.org/issue30822#msg297734

This revert is part of the new policy to keep buildbots green:
https://mail.python.org/pipermail/python-committers/2017-June/004588.html

The revert is just a solution to get more time to fix a proper fix, before reapply the commit.

@vstinner vstinner merged commit 8207c17 into master Jul 5, 2017

3 checks passed

bedevere/issue-number Issue number 30822 found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vstinner vstinner deleted the revert-2530-bpo-30822 branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment