bpo-42830: Update the documentation for tempfile.mkstemp #27075
Conversation
…t user is responsible for closing the file descriptor while closing the created file.
Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
|
Can you also update line 193 to replace 'handle' with 'file descriptor' (for consistency with os.close)? |
Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
|
I do not know the difference between the two words in OS context. I am not sure. |
|
This PR is stale because it has been open for 30 days with no activity. |
| for deleting the temporary file when done with it. If a large number of file | ||
| descriptors are created, your program may run into a per-process limit and raise an :exc:`OSError`. | ||
| You can avoid this issue by closing file descriptors with :func:`os.close`. |
There was a problem hiding this comment.
I would just say something like "the user of :func:mskstemp is responsible for deleting the temporary file and closing the file descriptor". Lots of things can cause you to run out of FDs, this isn't the place to describe the exact behavior.
|
Check this please... thanks for letting me be part of this project, and have done 8 contributions just that fact puts a smile in my face. |
github-actions
bot
removed
the
stale
|
@srinivasreddy Would you still interested in giving the PR a quick update per the review? |
|
Sure. I would do it in a day or two. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
bpo-42830: Update the documentation for tempfile.mkstemp function that user is responsible for closing the file descriptor while closing the created file.
https://bugs.python.org/issue42830