New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30822: Exclude tzdata from regrtest --all #2775

Merged
merged 4 commits into from Jul 20, 2017

Conversation

Projects
None yet
6 participants
@vstinner
Member

vstinner commented Jul 20, 2017

When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

bpo-30822: Exclude tzdata from regrtest --all
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jul 20, 2017

Member

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

cc @musically-ut

Member

vstinner commented Jul 20, 2017

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

cc @musically-ut

Travis CI: remove -tzdata
Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now
excluded from -u all.
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jul 20, 2017

Member

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

Hum, since I now want to backport this change to other branches (especially for the extralargefile fix), I added the NEWS entry ;-)

Member

vstinner commented Jul 20, 2017

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

Hum, since I now want to backport this change to other branches (especially for the extralargefile fix), I added the NEWS entry ;-)

@vstinner vstinner merged commit 5b392bb into python:master Jul 20, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
bedevere/issue-number Issue number 30822 found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vstinner vstinner deleted the vstinner:buildbottest branch Jul 20, 2017

vstinner added a commit to vstinner/cpython that referenced this pull request Jul 20, 2017

bpo-30822: Exclude tzdata from regrtest --all (python#2775)
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)
@bedevere-bot

This comment has been minimized.

Show comment
Hide comment
@bedevere-bot

bedevere-bot Jul 20, 2017

GH-2777 is a backport of this pull request to the 3.6 branch.

bedevere-bot commented Jul 20, 2017

GH-2777 is a backport of this pull request to the 3.6 branch.

vstinner added a commit to vstinner/cpython that referenced this pull request Jul 20, 2017

bpo-30822: Exclude tzdata from regrtest --all (python#2775)
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)
@bedevere-bot

This comment has been minimized.

Show comment
Hide comment
@bedevere-bot

bedevere-bot Jul 20, 2017

GH-2781 is a backport of this pull request to the 3.5 branch.

bedevere-bot commented Jul 20, 2017

GH-2781 is a backport of this pull request to the 3.5 branch.

vstinner added a commit that referenced this pull request Jul 20, 2017

bpo-30822: Exclude tzdata from regrtest --all (#2775) (#2777)
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)

vstinner added a commit that referenced this pull request Jul 20, 2017

bpo-30822: Exclude tzdata from regrtest --all (#2775) (#2781)
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)
@miss-islington

This comment has been minimized.

Show comment
Hide comment
@miss-islington

miss-islington Sep 13, 2017

Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒🤖

miss-islington commented Sep 13, 2017

Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Show comment
Hide comment
@miss-islington

miss-islington Sep 13, 2017

Sorry, @haypo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

miss-islington commented Sep 13, 2017

Sorry, @haypo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment