Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-30119: fix ftplib.FTP.putline() to throw an error for a illegal command (#1214) #2894

Merged
merged 1 commit into from Jul 26, 2017

Conversation

@corona10
Copy link
Member

commented Jul 26, 2017

@@ -447,7 +450,7 @@ def test_exceptions(self):

def test_all_errors(self):
exceptions = (ftplib.error_reply, ftplib.error_temp, ftplib.error_perm,
ftplib.error_proto, ftplib.Error, IOError, EOFError)
ftplib.error_proto, ftplib.Error, OSError, EOFError)

This comment has been minimized.

Copy link
@vstinner

vstinner Jul 26, 2017

Member

What is the rationale for this change? It seems specific to Python 3 where all OS-like exceptions have be replaced by a single OSError. On Python 2.7, you really want IOError. Please revert this change, to repair failing tests.

This comment has been minimized.

Copy link
@corona10

corona10 Jul 26, 2017

Author Member

@Haypo Oh, you are right. Thank you for comment.

@corona10 corona10 force-pushed the corona10:bpo-30119-2.7 branch from aea59d5 to 1aabc91 Jul 26, 2017

@corona10

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2017

Updated

@vstinner vstinner merged commit e5eae47 into python:2.7 Jul 26, 2017

3 checks passed

bedevere/issue-number Issue number 30119 found
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner

This comment has been minimized.

Copy link
Member

commented Jul 26, 2017

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.