bpo-37295: Optimize math.comb() and math.perm() #29090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
fast-perm-comb
branch
from
4c10e98
to
40853ae
Compare
Use divide-and-conquer algorithm for getting benefit of Karatsuba multiplication of large numbers. Do calculations for comb() in C unsigned long long instead of Python integers if possible.
serhiy-storchaka
force-pushed
the
fast-perm-comb
branch
from
40853ae
to
9fd696a
Compare
|
Minor typo in the commit message, you already fixed it in GitHub :-) "devide-and => divide-and". Just be careful when you merge the PR, GitHub uses the commit message, not the PR description. |
|
Benchmarks are quite impressive! https://bugs.python.org/issue37295#msg404208 |
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use divide-and-conquer algorithm for getting benefit of Karatsuba
multiplication of large numbers.
Do calculations
for comb()in C unsigned long long instead of Pythonintegers if possible.
https://bugs.python.org/issue37295