Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-20849: allow existing directory in shutil.copytree #2977

Closed
wants to merge 1 commit into from

Conversation

@ofek
Copy link

commented Aug 1, 2017

This is a legacy thing that wasn't updated with https://docs.python.org/3/library/os.html#os.makedirs

https://bugs.python.org/issue20849

Let us not bikeshed this time!

@ofek ofek changed the title allow existing directory in shutil.copytree bpo-20849: allow existing directory in shutil.copytree Aug 1, 2017

@olivier-grech

This comment has been minimized.

Copy link

commented Feb 1, 2018

Should not we update the docstring too? Especially the The destination directory must not already exist. part.

@matrixise

This comment has been minimized.

Copy link
Member

commented Feb 1, 2018

make sense

@jnnnnn

This comment has been minimized.

Copy link

commented Mar 15, 2018

I need this!

@ned-deily

This comment has been minimized.

Copy link
Member

commented Jun 7, 2018

@ofek Thanks for the PR and sorry that it has languished. But the PR cannot be accepted as is for two reasons: one, it ignores the discussion on the bug tracker about why changing the semantics of shutil.copytree to unconditionally ignore existing destination directories may be problematic; and two, we require PRs to be submitted against the cpython master branch, not a maintenance branch like 3.6; if a core developer decides to accept and merge a PR against master, they will decide whether any backports to maintenance branches are appropriate. Thus, I am closing the PR against 3.6. If you are still interested in pursuing this, perhaps making a new PR against master from the originally submitted patch might be a way forward.

https://devguide.python.org/#status-of-python-branches

@ned-deily ned-deily closed this Jun 7, 2018

@ofek ofek deleted the ofek:patch-1 branch Jun 7, 2018

@jab

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2018

Hi @ned-deily, I picked this back up in #8792 and addressed the outstanding concerns here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.