From 05572d2e7b0194b7568ae93ca1e2ae9b8b7f25f3 Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Thu, 6 Jan 2022 21:16:01 +0100 Subject: [PATCH 1/6] Close stale PRs without signed CLA --- .github/workflows/stale.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index e3b8b9f942d18a..85eb108348a6c4 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -16,7 +16,18 @@ jobs: - uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }} + exempt-pr-labels: 'CLA not signed' stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity.' stale-pr-label: 'stale' days-before-stale: 30 days-before-close: -1 + + - uses: actions/stale@v4 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + only-pr-labels: 'CLA not signed' + stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within one week, it will be closed.' + stale-pr-label: 'stale' + close-pr-message: 'Closing this stale PR because the CLA is still not signed.' + days-before-stale: 30 + days-before-close: 7 From b14cf5584b76bd23430e428ad7c0a554b20371d0 Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Sun, 9 Jan 2022 13:55:59 +0100 Subject: [PATCH 2/6] =?UTF-8?q?Address=20=C5=81ukasz'=20remarks?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/stale.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 85eb108348a6c4..05779a00336db2 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -26,8 +26,8 @@ jobs: with: repo-token: ${{ secrets.GITHUB_TOKEN }} only-pr-labels: 'CLA not signed' - stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within one week, it will be closed.' + stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing' stale-pr-label: 'stale' close-pr-message: 'Closing this stale PR because the CLA is still not signed.' days-before-stale: 30 - days-before-close: 7 + days-before-close: 14 From f405b931ac0df39cf4403b11a81a10068cfc484e Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Mon, 10 Jan 2022 10:16:39 +0100 Subject: [PATCH 3/6] Name each step for improved logging --- .github/workflows/stale.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 05779a00336db2..d624cc76de7062 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -13,7 +13,8 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/stale@v4 + - name: "Check PR's with 'CLA signed' label" + uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }} exempt-pr-labels: 'CLA not signed' @@ -22,7 +23,8 @@ jobs: days-before-stale: 30 days-before-close: -1 - - uses: actions/stale@v4 + - name: "Check PR's with 'CLA not signed' label" + uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }} only-pr-labels: 'CLA not signed' From 26028a57e8c71f5d621386a25c4e5ae76fc11a0e Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Mon, 10 Jan 2022 10:17:04 +0100 Subject: [PATCH 4/6] Use only-pr-labels iso. exempt-pr-labels --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index d624cc76de7062..5f9fc87b7fca60 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -17,7 +17,7 @@ jobs: uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }} - exempt-pr-labels: 'CLA not signed' + only-pr-labels: 'CLA signed' stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity.' stale-pr-label: 'stale' days-before-stale: 30 From 007570b7d0e5e1bbd21a001a577def98c06e60ec Mon Sep 17 00:00:00 2001 From: Erlend Egeberg Aasland Date: Mon, 10 Jan 2022 11:24:11 +0100 Subject: [PATCH 5/6] Plural, not genitive Co-authored-by: Hugo van Kemenade --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 5f9fc87b7fca60..18ba959e9a3ce9 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - - name: "Check PR's with 'CLA signed' label" + - name: "Check PRs with 'CLA signed' label" uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }} From 258a4752c0e6bf1a3db53c0ea627a5559fee4493 Mon Sep 17 00:00:00 2001 From: Erlend Egeberg Aasland Date: Mon, 10 Jan 2022 11:24:17 +0100 Subject: [PATCH 6/6] Plural, not genitive Co-authored-by: Hugo van Kemenade --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 18ba959e9a3ce9..1214c21d27ebf1 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -23,7 +23,7 @@ jobs: days-before-stale: 30 days-before-close: -1 - - name: "Check PR's with 'CLA not signed' label" + - name: "Check PRs with 'CLA not signed' label" uses: actions/stale@v4 with: repo-token: ${{ secrets.GITHUB_TOKEN }}