New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31159: fix language switch regex on unknown yet built languages. … #3051

Merged
merged 2 commits into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@JulienPalard
Member

JulienPalard commented Aug 9, 2017

…(#3039)

This fix a regex issue (a missing non-matching group around an 'or'
list) and the specific possible case where a translation is built but
not yet in known by the picker, but not explicitly listing possible
languages in the regex.
(cherry picked from commit 122081d)

https://bugs.python.org/issue31159

bpo-31159: fix language switch regex on unknown yet built languages. (#…
…3039)

This fix a regex issue (a missing non-matching group around an 'or'
list) and the specific possible case where a translation is built but
not yet in known by the picker, but not explicitly listing possible
languages in the regex.
(cherry picked from commit 122081d)
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Aug 10, 2017

Member

I would prefer to append the PR #3052 commit into this PR.

Member

vstinner commented Aug 10, 2017

I would prefer to append the PR #3052 commit into this PR.

@JulienPalard

This comment has been minimized.

Show comment
Hide comment
@JulienPalard

JulienPalard Aug 10, 2017

Member

OK I'll do.

Member

JulienPalard commented Aug 10, 2017

OK I'll do.

@vstinner vstinner merged commit e8e7fba into python:3.6 Aug 10, 2017

2 checks passed

bedevere/issue-number Issue number 31159 found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Aug 13, 2017

bpo-31159: fix language switch regex on unknown yet built languages. … (
#3051)

* bpo-31159: fix language switch regex on unknown yet built languages. (#3039)

This fix a regex issue (a missing non-matching group around an 'or'
list) and the specific possible case where a translation is built but
not yet in known by the picker, but not explicitly listing possible
languages in the regex.
(cherry picked from commit 122081d)

* bpo-31149: Doc: Add Japanese to the language switcher. (#3028)

(cherry picked from commit c82b7f3)

(cherry picked from commit e8e7fba)

vstinner added a commit that referenced this pull request Aug 13, 2017

bpo-31159: fix language switch regex on unknown yet built languages. … (
#3051) (#3081)

* bpo-31159: fix language switch regex on unknown yet built languages. (#3039)

This fix a regex issue (a missing non-matching group around an 'or'
list) and the specific possible case where a translation is built but
not yet in known by the picker, but not explicitly listing possible
languages in the regex.
(cherry picked from commit 122081d)

* bpo-31149: Doc: Add Japanese to the language switcher. (#3028)

(cherry picked from commit c82b7f3)

(cherry picked from commit e8e7fba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment