Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-26669: Fix nan arg value error in pytime.c #3085
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
changed the title from
bpo-26669: Fix nan input error in pytime.c
bpo-26669: Fix nan arg value error in pytime.c
Aug 13, 2017
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase
And if you don't make the requested changes, you will be put in the comfy chair!
@Haypo I'm really sorry for the delay in writing the code.
System: Ubuntu 16.04 x86
I tested the following code in
# test nan for time_rnd, _ in ROUNDING_MODES: with self.assertRaises(ValueError): pytime_converter(float('nan'), time_rnd)
Here are the results:
...so I tested one by one.
If the result is the same as expected, I will replace the passed test code with the changed