From 1433e91cfcd928dcdf752d97f127b519da3074aa Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Wed, 2 Feb 2022 18:14:50 +0000 Subject: [PATCH 1/2] bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion --- Lib/test/test_importlib/test_windows.py | 15 ++++++++++++--- .../2022-02-02-18-14-38.bpo-46616.URvBtE.rst | 2 ++ 2 files changed, 14 insertions(+), 3 deletions(-) create mode 100644 Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst diff --git a/Lib/test/test_importlib/test_windows.py b/Lib/test/test_importlib/test_windows.py index b3e8e7e6d63fcd..dabcaf030d22f1 100644 --- a/Lib/test/test_importlib/test_windows.py +++ b/Lib/test/test_importlib/test_windows.py @@ -60,17 +60,26 @@ def setup_module(machinery, name, path=None): root = machinery.WindowsRegistryFinder.REGISTRY_KEY key = root.format(fullname=name, sys_version='%d.%d' % sys.version_info[:2]) + base_key = "Software\\Python\\PythonCore\\{}.{}".format(*sys.version_info[:2]) try: with temp_module(name, "a = 1") as location: + try: + OpenKey(HKEY_CURRENT_USER, base_key) + if machinery.WindowsRegistryFinder.DEBUG_BUILD: + delete_key = os.path.dirname(key) + else: + delete_key = key + except OSError: + delete_key = base_key subkey = CreateKey(HKEY_CURRENT_USER, key) if path is None: path = location + ".py" SetValue(subkey, "", REG_SZ, path) yield finally: - if machinery.WindowsRegistryFinder.DEBUG_BUILD: - key = os.path.dirname(key) - delete_registry_tree(HKEY_CURRENT_USER, key) + if delete_key: + print("DELETING", delete_key) + delete_registry_tree(HKEY_CURRENT_USER, delete_key) @unittest.skipUnless(sys.platform.startswith('win'), 'requires Windows') diff --git a/Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst b/Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst new file mode 100644 index 00000000000000..31c63c3d8f1810 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2022-02-02-18-14-38.bpo-46616.URvBtE.rst @@ -0,0 +1,2 @@ +Ensures ``test_importlib.test_windows`` cleans up registry keys after +completion. From 4b57d217eb512d36aaeaca5cb08c980a415ab129 Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Wed, 2 Feb 2022 18:16:47 +0000 Subject: [PATCH 2/2] Improve key name calculation --- Lib/test/test_importlib/test_windows.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_importlib/test_windows.py b/Lib/test/test_importlib/test_windows.py index dabcaf030d22f1..b7dfe865a03a97 100644 --- a/Lib/test/test_importlib/test_windows.py +++ b/Lib/test/test_importlib/test_windows.py @@ -60,7 +60,10 @@ def setup_module(machinery, name, path=None): root = machinery.WindowsRegistryFinder.REGISTRY_KEY key = root.format(fullname=name, sys_version='%d.%d' % sys.version_info[:2]) - base_key = "Software\\Python\\PythonCore\\{}.{}".format(*sys.version_info[:2]) + base_key = "Software\\Python\\PythonCore\\{}.{}".format( + sys.version_info.major, sys.version_info.minor) + assert key.casefold().startswith(base_key.casefold()), ( + "expected key '{}' to start with '{}'".format(key, base_key)) try: with temp_module(name, "a = 1") as location: try: @@ -78,7 +81,6 @@ def setup_module(machinery, name, path=None): yield finally: if delete_key: - print("DELETING", delete_key) delete_registry_tree(HKEY_CURRENT_USER, delete_key)