New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31320: No traceback to sys.stderr in test_ssl #3360

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
6 participants
@tiran
Member

tiran commented Sep 5, 2017

In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue31320

bpo-31320: No traceback to sys.stderr in test_ssl
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>
@vstinner

LGTM.

@tiran tiran merged commit 305e56c into python:master Sep 5, 2017

4 checks passed

bedevere/issue-number Issue number 31320 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Show comment
Hide comment
@miss-islington

miss-islington Sep 5, 2017

🐍🍒🤖 Thanks @tiran for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

miss-islington commented Sep 5, 2017

🐍🍒🤖 Thanks @tiran for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@tiran tiran deleted the tiran:bpo-31320_test_ssl_traceback branch Sep 5, 2017

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 5, 2017

[3.6] bpo-31320: No traceback to sys.stderr in test_ssl (pythonGH-3360)
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 305e56c)
@bedevere-bot

This comment has been minimized.

Show comment
Hide comment
@bedevere-bot

bedevere-bot Sep 5, 2017

GH-3369 is a backport of this pull request to the 3.6 branch.

bedevere-bot commented Sep 5, 2017

GH-3369 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Sep 6, 2017

[3.6] bpo-31320: No traceback to sys.stderr in test_ssl (GH-3360) (GH…
…-3369)

In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 305e56c)

GadgetSteve added a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017

bpo-31320: No traceback to sys.stderr in test_ssl (#3360)
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>

daxlab added a commit to daxlab/cpython that referenced this pull request Oct 1, 2017

bpo-31320: No traceback to sys.stderr in test_ssl (python#3360)
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>

@Mariatta Mariatta removed the awaiting merge label Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment