Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-7938: the makesetup script now respects macro define arguments of… #4338

Open
wants to merge 2 commits into
base: master
from

Conversation

@michaelgrahamevans
Copy link

commented Nov 8, 2017

… the form '-Dname=definition'

Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.

https://bugs.python.org/issue7938

Michael Evans
bpo-7938: the makesetup script now respects macro define arguments of…
… the form '-Dname=definition'

Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.
@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Nov 8, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@michaelgrahamevans

This comment has been minimized.

Copy link
Author

commented Nov 9, 2017

I have signed the CLA.

Michael Evans
@benjaminp

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

I wonder if we can simplify this by assuming the make variables are of the form ^SOME_VAR=? (i.e., one word at the beginning of a line).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.