Skip to content

gh-52186: the makesetup script now respects macro define arguments of… #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

michaelgrahamevans
Copy link

@michaelgrahamevans michaelgrahamevans commented Nov 8, 2017

… the form '-Dname=definition'

Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.

https://bugs.python.org/issue7938

… the form '-Dname=definition'

Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@michaelgrahamevans
Copy link
Author

I have signed the CLA.

@benjaminp
Copy link
Contributor

I wonder if we can simplify this by assuming the make variables are of the form ^SOME_VAR=? (i.e., one word at the beginning of a line).

@MaxwellDupre
Copy link
Contributor

Is this still relevant?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2022
@arhadthedev arhadthedev changed the title bpo-7938: the makesetup script now respects macro define arguments of… gh-52186: the makesetup script now respects macro define arguments of… May 5, 2023
@arhadthedev arhadthedev added build The build process and cross-build and removed stale Stale PR or inactive for long period of time. labels May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review build The build process and cross-build stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants