Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-7938: the makesetup script now respects macro define arguments of… #4338
… the form '-Dname=definition'
Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!