New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-32551: Consistently configure sys.path[0] (GH-575) #5197

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@ncoghlan
Contributor

ncoghlan commented Jan 16, 2018

Directory and zipfile execution previously added
the parent directory of the directory or zipfile
as sys.path[0] and then subsequently overwrote
it with the directory or zipfile itself.

This caused problems in isolated mode, as it
overwrote the "stdlib as a zip archive" entry
in sys.path, as the parent directory was
never added.

The attempted fix to that issue in bpo-29319
created the opposite problem in non-isolated
mode, by potentially leaving the parent
directory on sys.path instead of overwriting it.

This change fixes the root cause of the problem
by removing the whole "add-and-overwrite" dance
for sys.path[0], and instead simply never adds
the parent directory to sys.path in the first
place.

(cherry picked from commit d2977a3)

https://bugs.python.org/issue32551

[3.5] bpo-32551: Consistently configure sys.path[0]
Directory and zipfile execution previously added
the parent directory of the directory or zipfile
as sys.path[0] and then subsequently overwrote
it with the directory or zipfile itself.

This caused problems in isolated mode, as it
overwrote the "stdlib as a zip archive" entry
in sys.path, as the parent directory was
never added.

The attempted fix to that issue in bpo-29319
created the opposite problem in *non*-isolated
mode, by potentially leaving the parent
directory on sys.path instead of overwriting it.

This change fixes the root cause of the problem
by removing the whole "add-and-overwrite" dance
for sys.path[0], and instead simply never adds
the parent directory to sys.path in the first
place.

(cherry picked from commit d2977a3)

@larryhastings larryhastings merged commit 891c91d into python:3.5 Jan 23, 2018

4 checks passed

bedevere/issue-number Issue number 32551 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@larryhastings

This comment has been minimized.

Contributor

larryhastings commented Jan 23, 2018

Thanks!

@ncoghlan ncoghlan deleted the ncoghlan:backport-d2977a3-3.5 branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment