Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] bpo-32592: Drop support for Windows Vista #5231
AppVeyor compilation failed with: "C:\Program Files (x86)\Windows Kits\10\Include\10.0.16299.0\shared\sdkddkver.h(289): fatal error C1189: #error: NTDDI_VERSION setting conflicts with _WIN32_WINNT setting [C:\projects\cpython\PCbuild\pythoncore.vcxproj]"
@zooba: Do you understand why my change breaks the compilation?
"posixmodule.obj : error LNK2001: unresolved external symbol _GetMaximumProcessorCount [C:\projects\cpython\PCbuild\pythoncore.vcxproj]"
Oh, my posixmodule.c change doesn't work :-(
Extract of pythoninfo:
I understand that AppVeyor runs Windows 10 and Python was built by Visual Studio 2017
"Remarks: To compile an application that uses this function, set _WIN32_WINNT >= 0x0601. For more information, see Using the Windows Headers."
Aha. I need to try to understand why changing _WIN32_WINNT failed. But my Windows VM is down :-)