GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft, need tests
Merge branch 'master' into asyncio-streams
Move _closed into protocol
Merge branch 'master' of https://github.com/python/cpython into async…
Please go ahead and add the tests.
Rename test suite
Done, please review
Is this a new API method? Please document it if it is.
Forgot about the change - but exposing the method makes sense
I think it's a bit too low-level. Can you imagine a good use case for async/await code that uses writer and reader?
StreamWriter exposes all Transport methods except flow control related.
is_closing() is not about flow control, I see no reason to not implement it.
OK, go ahead.
Please review again.
One last note: I don't think you want to use ReST formatting in NEWS entries. This would read better:
Implement wait_closed() and is_closing() methods for StreamWriter.
There is no standard for blurb text, the format of messages is mixed.
Some people use ReST, others prefer plain text.
If you briefly look on these files you'll see both cases.
I have no personal preference.
I don't really care.