Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-working attempt to introduce := as an assignment operator #6333

Closed
wants to merge 17 commits into from

Conversation

@Rosuav
Copy link
Contributor

commented Apr 1, 2018

NOT FOR MERGING

This PR is just to make the branch more visible to maintainers, incl @gvanrossum

@@ -83,7 +83,7 @@ with_item: test ['as' expr]
except_clause: 'except' [test ['as' NAME]]
suite: simple_stmt | NEWLINE INDENT stmt+ DEDENT

test: or_test ['if' or_test 'else' test] | lambdef
test: [or_test ':='] or_test ['if' or_test 'else' test] | lambdef

This comment has been minimized.

Copy link
@gvanrossum

gvanrossum Apr 1, 2018

Member

Try or_test [':= or_test] instead.

@Rosuav Rosuav force-pushed the Rosuav:assignment-expressions branch from 8dcb966 to 22547d4 Apr 10, 2018

@Rosuav

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2018

The test suite now passes except for those tests which specifically check for the specialness of the first iterable.

@Rosuav Rosuav force-pushed the Rosuav:assignment-expressions branch from 28e0222 to 8886537 Apr 15, 2018

@Rosuav Rosuav force-pushed the Rosuav:assignment-expressions branch from 8886537 to 161aad8 Apr 17, 2018

@Rosuav Rosuav requested a review from ilevkivskyi as a code owner Apr 17, 2018

Remove tests of outermost-iterable precomputation.
These tests would remain valid if genexp priming is implemented.
@csabella

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

This was implemented under bpo-35224 and #10497.

@csabella csabella closed this May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.