Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-33097: Fix submit accepting callable after executor shutdown by interpreter exit (GH-6144) #6445

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
5 participants
@miss-islington
Copy link

miss-islington commented Apr 10, 2018

Executors in concurrent.futures accepted tasks after executor was shutdown by interpreter exit. Tasks were left in PENDING state forever. This fix changes submit to instead raise a RuntimeError.
(cherry picked from commit c4b695f)

Co-authored-by: Mark Nemec mrknmc@me.com

https://bugs.python.org/issue33097

bpo-33097: Fix submit accepting callable after executor shutdown by i…
…nterpreter exit (GH-6144)

Executors in concurrent.futures accepted tasks after executor was shutdown by interpreter exit. Tasks were left in PENDING state forever. This fix changes submit to instead raise a RuntimeError.
(cherry picked from commit c4b695f)

Co-authored-by: Mark Nemec <mrknmc@me.com>
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Apr 10, 2018

@mrknmc and @pitrou: Backport status check is done, and it's a success .

@pitrou pitrou merged commit b262659 into python:3.7 Apr 10, 2018

4 checks passed

bedevere/issue-number Issue number 33097 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Apr 10, 2018

Thanks, @pitrou!

@miss-islington miss-islington deleted the miss-islington:backport-c4b695f-3.7 branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.