Travis CI: run rstlint.py in the docs job #68

Merged
merged 1 commit into from Feb 13, 2017

Projects

None yet

6 participants

@haypo
Contributor
haypo commented Feb 13, 2017

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

@haypo haypo Travis CI: run rstlint.py in the docs job
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
0ffa5e4
@haypo haypo merged commit 2b50186 into python:master Feb 13, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@JDLH
Contributor
JDLH commented Feb 13, 2017

Thank you for catching this. I authored the trailing spaces in those two lines.
My "test suite" for the documentation was make html. I didn't know to run rstlint.py as well.

It would have helped me to have this check in some sort of make test in Doc/Makefile. It would also have helped me to have a reference to this doc testing in https://cpython-devguide.readthedocs.io/docquality.html .

@haypo
Contributor
haypo commented Feb 13, 2017
@zware
Member
zware commented Feb 14, 2017

Note that running rstlint is available as make check.

@methane methane added a commit to methane/cpython that referenced this pull request Feb 14, 2017
@haypo @methane haypo + methane Travis CI: run rstlint.py in the docs job (#68)
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
a78efcb
@methane methane added a commit to methane/cpython that referenced this pull request Feb 14, 2017
@haypo @methane haypo + methane Travis CI: run rstlint.py in the docs job (#68)
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
8eaa1d0
@berkerpeksag
Member

Note that running rstlint is available as make check.

Good point, opened #96. Thanks!

@haypo haypo added a commit to haypo/cpython that referenced this pull request Feb 15, 2017
@haypo @haypo haypo + haypo Travis CI: run rstlint.py in the docs job (#68)
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)
c7f34bc
@haypo haypo added a commit that referenced this pull request Feb 15, 2017
@haypo haypo Backport36 doc fixes: PR#68 and PR#124 (#125)
* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
b300c66
@haypo haypo added a commit to haypo/cpython that referenced this pull request Feb 16, 2017
@haypo @haypo haypo + haypo Backport35 doc fixes: PR#68 and PR#124 (#125)
* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
(cherry picked from commit b300c66)
ce6de13
@haypo haypo added a commit that referenced this pull request Feb 16, 2017
@haypo haypo Backport35 doc fixes: PR#68 and PR#124 (#125) (#126)
* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
(cherry picked from commit b300c66)
5e04dfe
@ncoghlan ncoghlan added a commit that referenced this pull request Feb 19, 2017
@methane @ncoghlan methane + ncoghlan [backport to 3.6] bpo-29529: Add .travis.yml to 3.6 branch (#25)
* Add .travis.yml to 3.6 branch

* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

* Only run CI checks when appropriate files have changed (#74)

Closes python/core-workflow#14

* Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
3337d33
@ncoghlan ncoghlan added a commit that referenced this pull request Feb 19, 2017
@methane @ncoghlan methane + ncoghlan [backport to 3.5] bpo-29529: Add .travis.yml to 3.5 branch (#26)
* Add .travis.yml to 3.5 branch

* Only run CI checks when appropriate files have changed (#74)

Closes python/core-workflow#14

* Travis CI: run rstlint.py in the docs job (#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

* Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
24bfe15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment