New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-33612: Remove PyThreadState_Clear() assertion (GH-7069) #7074

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
5 participants
@miss-islington

miss-islington commented May 23, 2018

bpo-25612, bpo-33612: Remove an assertion from PyThreadState_Clear()
which failed at Python shutdown or on fork if a thread was running a
generator.
(cherry picked from commit b6dccf5)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33612

bpo-33612: Remove PyThreadState_Clear() assertion (GH-7069)
bpo-25612, bpo-33612: Remove an assertion from PyThreadState_Clear()
which failed at Python shutdown or on fork if a thread was running a
generator.
(cherry picked from commit b6dccf5)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@vstinner

LGTM, good bot.

@miss-islington

This comment has been minimized.

Show comment
Hide comment
@miss-islington

miss-islington May 23, 2018

@vstinner: Backport status check is done, and it's a failure .

miss-islington commented May 23, 2018

@vstinner: Backport status check is done, and it's a failure .

@ned-deily ned-deily merged commit 508d769 into python:3.7 May 23, 2018

7 of 8 checks passed

VSTS: macOS-PR macOS-PR_20180523.27 failed
Details
VSTS: Linux-PR Linux-PR_20180523.27 succeeded
Details
VSTS: Windows-PR Windows-PR_20180523.27 succeeded
Details
VSTS: docs docs_20180523.31 succeeded
Details
bedevere/issue-number Issue number 33612 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Show comment
Hide comment
@miss-islington

miss-islington commented May 23, 2018

Thanks, @ned-deily!

@miss-islington miss-islington deleted the miss-islington:backport-b6dccf5-3.7 branch May 23, 2018

@ned-deily

This comment has been minimized.

Show comment
Hide comment
@ned-deily

ned-deily May 23, 2018

Member

(To speed things along, I've merged the 3.7 backport. Thanks @vstinner and all the reviewers!)

Member

ned-deily commented May 23, 2018

(To speed things along, I've merged the 3.7 backport. Thanks @vstinner and all the reviewers!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment