Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194

Merged
merged 1 commit into from May 29, 2018

Conversation

@1st1
Copy link
Member

commented May 29, 2018

@asvetlov
Copy link
Contributor

left a comment

lgtm

@asvetlov asvetlov merged commit 2179022 into python:master May 29, 2018

9 checks passed

VSTS: Linux-PR Linux-PR_20180529.07 succeeded
Details
VSTS: Linux-PR-Coverage Linux-PR-Coverage_20180529.17 succeeded
Details
VSTS: Windows-PR Windows-PR_20180529.07 succeeded
Details
VSTS: docs docs_20180529.21 succeeded
Details
VSTS: macOS-PR macOS-PR_20180529.07 succeeded
Details
bedevere/issue-number Issue number 33654 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented May 29, 2018

Thanks @1st1 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

commented May 29, 2018

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot

This comment has been minimized.

Copy link

commented May 29, 2018

GH-7198 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request May 29, 2018
bpo-33654: Support protocol type switching in SSLTransport.set_protoc…
…ol() (pythonGH-7194)

(cherry picked from commit 2179022)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request May 29, 2018
bpo-33654: Support protocol type switching in SSLTransport.set_protoc…
…ol() (GH-7194)

(cherry picked from commit 2179022)

Co-authored-by: Yury Selivanov <yury@magic.io>
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2018
yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.