New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-59795: distinct python-config from pkg-config python #737
Conversation
Fix output of 'python-config' for creating loadable Python modules. Fix output of 'pkg-config python' for linking against the interpreter.
@haubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ned-deily and @loewis to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please re base this or want new taker for this?
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This PR is stale because it has been open for 30 days with no activity. |
Unfortunately, meanwhile I have moved on to completely different tasks, and have neither the environment nor the time any more to look into that again: Feel free to pick up! |
This PR is stale because it has been open for 30 days with no activity. |
Meta: added GitHub links to OP and comments for easier navigation. |
In that case, I propose to close this PR. If anybody wants to pick this up, they'll be better off by starting from scratch; the build system has seen huge changes the recent years. We should also consider closing the linked issue; I'm unsure if this is a real problem anymore. |
Fix output of 'python-config' for creating loadable Python modules.
Fix output of 'pkg-config python' for linking against the interpreter.