Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-27575: port set intersection logic into dictview intersection #7696
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
When your account is ready, please add a comment in this pull request
Thanks again for your contribution, we look forward to reviewing it!
I wasn't sure if that guidance applied here, because I didn't apply @dsu1995 patches and them make a new commit. Instead, I cherry-picked from his git branch.
As such, David Su is already listed as the sole author of his commits.
If this is not the preferred option, I can redo this branch so that it does not have @dsu1995's commits and instead just has a commit where I applied his patch. In that commit I will list him as the Co-Author in the commit message.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase