Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26544: Get rid of dependence from distutils in platform. #8356

Merged

Conversation

Projects
None yet
5 participants
@serhiy-storchaka
Copy link
Member

commented Jul 20, 2018

# http://php.net/manual/en/function.version-compare.php

_ver_stages = {
# any string not found in this dict

This comment has been minimized.

Copy link
@malemburg

malemburg Aug 21, 2018

Member

I guess the comment should read: "any string not found in this dict, will get 0 assigned" or something similar.

This comment has been minimized.

Copy link
@serhiy-storchaka

serhiy-storchaka Aug 25, 2018

Author Member

Thank you for your suggestion. Done.

@serhiy-storchaka serhiy-storchaka merged commit 7d81e8f into python:master Aug 27, 2018

9 checks passed

VSTS: Linux-PR Linux-PR_20180825.11 succeeded
Details
VSTS: Linux-PR-Coverage Linux-PR-Coverage_20180825.05 succeeded
Details
VSTS: Windows-PR Windows-PR_20180825.11 succeeded
Details
VSTS: docs docs_20180825.11 succeeded
Details
VSTS: macOS-PR macOS-PR_20180825.11 succeeded
Details
bedevere/issue-number Issue number 26544 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Aug 27, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒🤖

@serhiy-storchaka serhiy-storchaka deleted the serhiy-storchaka:platform-version-compare branch Aug 27, 2018

@miss-islington

This comment has been minimized.

Copy link

commented Aug 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d81e8f5995df6980a1a02923e224a481375f130 3.7

@miss-islington

This comment has been minimized.

Copy link

commented Aug 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d81e8f5995df6980a1a02923e224a481375f130 3.6

@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 27, 2018

GH-8952 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 27, 2018

bpo-26544: Get rid of dependence from distutils in platform. (pythonG…
…H-8356)

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 28, 2018

[3.7] bpo-26544: Get rid of dependence from distutils in platform. (p…
…ythonGH-8356).

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 28, 2018

GH-8970 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 28, 2018

[3.6] bpo-26544: Get rid of dependence from distutils in platform. (p…
…ythonGH-8356).

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 28, 2018

GH-8971 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 4, 2018

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 4, 2018

[3.7] bpo-26544: Get rid of dependence from distutils in platform. (p…
…ythonGH-8356). (pythonGH-8970)

(cherry picked from commit 7d81e8f)
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2018

[2.7] [3.7] bpo-26544: Get rid of dependence from distutils in platfo…
…rm. (pythonGH-8356). (pythonGH-8970)

(cherry picked from commit 7d81e8f).
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

vstinner added a commit that referenced this pull request Sep 5, 2018

[3.7] bpo-26544: Get rid of dependence from distutils in platform. (G…
…H-8356) (GH-8970) (GH-9061)

(cherry picked from commit 7d81e8f)
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

vstinner added a commit that referenced this pull request Sep 5, 2018

bpo-26544: Get rid of dependence from distutils in platform. (GH-8356) (
GH-8952)

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

lisroach added a commit to lisroach/cpython that referenced this pull request Sep 12, 2018

@serhiy-storchaka serhiy-storchaka removed their assignment Sep 22, 2018

yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.