Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33187: Fix document ElementInclude (XInclude) support in ElementTree issue #8861

Merged
merged 10 commits into from Sep 11, 2019

Conversation

@bansalanjali2512
Copy link
Contributor

commented Aug 22, 2018

@eamanu
eamanu approved these changes Aug 23, 2018
@scoder
Copy link
Contributor

left a comment

Thanks! I left some comments.

Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
@scoder

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Please also fix the travis errors. There seems to be trailing whitespace in the file.

@scoder

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

Any update on this? It would be nice to get this ready to be merged.

@tirkarthi

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

There are some trailing spaces in the PR. Please try running make patchcheck locally that will fix the whitespace related errors.

scoder added 7 commits Sep 11, 2019
@scoder
scoder approved these changes Sep 11, 2019

@scoder scoder merged commit 97b817e into python:master Sep 11, 2019

4 checks passed

Azure Pipelines PR #20190911.121 succeeded
Details
bedevere/issue-number Issue number 33187 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p…
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15958 is a backport of this pull request to the 3.8 branch.

scoder added a commit that referenced this pull request Sep 11, 2019
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (G…
…H-8861) (GH-15958)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p…
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15972 is a backport of this pull request to the 3.7 branch.

scoder added a commit that referenced this pull request Sep 11, 2019
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (G…
…H-8861) (GH-15972)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.