New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34605, libregrtest: Avoid master/slave terms #9099

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
8 participants
@vstinner
Member

vstinner commented Sep 7, 2018

  • Rename --slaveargs to --worker-args
  • Rename run_tests_slave() to run_tests_worker()

https://bugs.python.org/issue34605

bpo-34605, libregrtest: Avoid master/slave terms
* Rename --slaveargs to --worker-args
* Rename run_tests_slave() to run_tests_worker()

@vstinner vstinner added the skip news label Sep 7, 2018

@vstinner vstinner merged commit 012f5b9 into python:master Sep 7, 2018

9 checks passed

Linux-PR #Linux-PR_20180907.20 succeeded
Details
Linux-PR-Coverage #Linux-PR-Coverage_20180907.16 succeeded
Details
Windows-PR #Windows-PR_20180907.20 succeeded
Details
bedevere/issue-number Issue number 34605 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs #docs_20180907.20 succeeded
Details
macOS-PR #macOS-PR_20180907.20 succeeded
Details

@vstinner vstinner deleted the vstinner:regrtest_master_slave branch Sep 7, 2018

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 12, 2018

bpo-34605, libregrtest: Rename --slaveargs to --worker-args (GH-9099)
Rename also run_tests_slave() to run_tests_worker().
@rsaleri

This comment was marked as off-topic.

Show comment
Hide comment
@rsaleri

rsaleri Sep 12, 2018

merged commit 012f5b9 into python:master
Oh, the irony...

rsaleri commented Sep 12, 2018

merged commit 012f5b9 into python:master
Oh, the irony...

@and3rson

This comment was marked as off-topic.

Show comment
Hide comment
@and3rson

and3rson Sep 12, 2018

I'm sure "Python" offends families of those who were killed by actual pythons (or by the funniest joke in the world). Let's rename it to NotAPython.

and3rson commented Sep 12, 2018

I'm sure "Python" offends families of those who were killed by actual pythons (or by the funniest joke in the world). Let's rename it to NotAPython.

@NiKiZe

This comment was marked as off-topic.

Show comment
Hide comment
@NiKiZe

NiKiZe Sep 13, 2018

Breaking change - is it really worth it - what comes next?

NiKiZe commented Sep 13, 2018

Breaking change - is it really worth it - what comes next?

@Marcon

This comment was marked as disruptive content.

Show comment
Hide comment
@Marcon

Marcon Sep 13, 2018

What if someone use variable named "slave" in code? We need interpreter-level check for that, and raise DiversityException in that case.

P.S. Is a joke. Please don't read this as proposal for next milestone in python.

Marcon commented Sep 13, 2018

What if someone use variable named "slave" in code? We need interpreter-level check for that, and raise DiversityException in that case.

P.S. Is a joke. Please don't read this as proposal for next milestone in python.

@python python locked and limited conversation to collaborators Sep 13, 2018

@python python deleted a comment from karolyipeter Sep 13, 2018

@python python deleted a comment from babadoctor Sep 13, 2018

@python python deleted a comment from rsaleri Sep 13, 2018

@serhiy-storchaka

This comment has been minimized.

Show comment
Hide comment
@serhiy-storchaka

serhiy-storchaka Sep 14, 2018

Member

This one LGTM. This is our internal API, and there are no any relations with existing common terminology. I always wondered why such bizarre name was used here.

Member

serhiy-storchaka commented Sep 14, 2018

This one LGTM. This is our internal API, and there are no any relations with existing common terminology. I always wondered why such bizarre name was used here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.