New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34605: childs => children #9102

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
5 participants
@vstinner
Member

vstinner commented Sep 7, 2018

@ericvsmith

This comment has been minimized.

Show comment
Hide comment
@ericvsmith

ericvsmith Sep 7, 2018

Member

Looks good to me!

Member

ericvsmith commented Sep 7, 2018

Looks good to me!

@ericvsmith

This comment has been minimized.

Show comment
Hide comment
@ericvsmith

ericvsmith Sep 7, 2018

Member

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

Member

ericvsmith commented Sep 7, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Sep 7, 2018

Member

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

works for me :-)

Member

vstinner commented Sep 7, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

works for me :-)

@vstinner vstinner merged commit 7e610bc into python:master Sep 7, 2018

9 checks passed

Linux-PR #Linux-PR_20180907.25 succeeded
Details
Linux-PR-Coverage #Linux-PR-Coverage_20180907.21 succeeded
Details
Windows-PR #Windows-PR_20180907.25 succeeded
Details
bedevere/issue-number Issue number 34605 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs #docs_20180907.25 succeeded
Details
macOS-PR #macOS-PR_20180907.25 succeeded
Details

@vstinner vstinner deleted the vstinner:pliant branch Sep 7, 2018

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 12, 2018

@perfide

This comment has been minimized.

Show comment
Hide comment
@perfide

perfide Sep 13, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

"pliant children" makes no sense.
It made sense as "pliant slave", a bad joke though.
I think "and its helper functions, like" is easier to understand.

perfide commented Sep 13, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

"pliant children" makes no sense.
It made sense as "pliant slave", a bad joke though.
I think "and its helper functions, like" is easier to understand.

@python python locked and limited conversation to collaborators Sep 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.