Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34605: Replace "pliant children" with "helpers" #9195

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
9 participants
@vstinner
Copy link
Member

vstinner commented Sep 11, 2018

In distutils.command.install, replace "pliant children" (previously,
it was "pliant slaves") with "helpers".

https://bugs.python.org/issue34605

bpo-34605: Replace "pliant children" with "helpers"
In distutils.command.install, replace "pliant children" (previously,
it was "pliant slaves") with "helpers".
@pitrou

pitrou approved these changes Sep 11, 2018

@vstinner

This comment has been minimized.

Copy link
Member Author

vstinner commented Sep 11, 2018

Copy of @gvanrossum comment:

I Googled a bit and it seems "pliant slave" is an old-fashioned way to refer to slaves, and even more demeaning than just "slave" -- I presume it was meant ironically by the original author. We should really replace the entire construct "pliant slaves" with a more neutral term. I don't think "children" is the right term -- I propose "helpers".

#9101 (comment)

@ericvsmith
Copy link
Member

ericvsmith left a comment

Looks good.

@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Sep 11, 2018

@vstinner: Status check is done, and it's a success .

@miss-islington miss-islington merged commit fa7dfae into python:master Sep 11, 2018

9 checks passed

Linux-PR #Linux-PR_20180911.94 succeeded
Details
Linux-PR-Coverage #Linux-PR-Coverage_20180911.71 succeeded
Details
Windows-PR #Windows-PR_20180911.94 succeeded
Details
bedevere/issue-number Issue number 34605 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs #docs_20180911.94 succeeded
Details
macOS-PR #macOS-PR_20180911.94 succeeded
Details

@vstinner vstinner deleted the vstinner:pliant branch Sep 11, 2018

@dolkensp

This comment was marked as disruptive content.

Copy link

dolkensp commented Sep 12, 2018

Anyone else find the irony in the source of this PR?

Oh, maybe I should have waited longer before merging this one :-( I'm wasn't 100% sure between "childs" and "children". Sorry, english is not my first language.

Knows just enough English to be offended, and break all future SEO helping people resolve issues in master/slave configurations, but not enough to know what to replace it with.

I can't wait for "helpers" to get confused with the numerous other uses that "helpers" already has across the CS world.

And before anyone tries to argue "but context" - if we were considering context, then we wouldn't be here to begin with.

@brettcannon

This comment has been minimized.

Copy link
Member

brettcannon commented Sep 12, 2018

@dolkensp your insult at Victor about his English skills is uncalled for; you simply could have pointed out that SEO would be affected.

Consider this a warning that insulting people is not tolerated under the Code of Conduct and if it happens again there will be ramifications.

@python python locked as too heated and limited conversation to collaborators Sep 12, 2018

@pitrou

This comment has been minimized.

Copy link
Member

pitrou commented Sep 12, 2018

Interesting. As a non-native English speaker myself, I would say that hesitating between "childs" and "children" is a sign that maybe one should wait for comments before merging a language-tweaking PR. Just saying ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.