Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34906: Doc: Fix typos (2) #9735

Merged
merged 3 commits into from Oct 6, 2018
Merged

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented Oct 5, 2018

Second turn for the typo in the doc, mainly for the Misc/ directory

https://bugs.python.org/issue34906

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll probably need to make a manual backport to 3.7 and 3.6 of the subsets that apply to each.

Misc/HISTORY Show resolved Hide resolved
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idlelib corrections will backport cleanly.

@matrixise
Copy link
Member Author

@vadmium here is my patch for mailformed thank you.

@matrixise
Copy link
Member Author

For this PR and the previous one, I used sphinxcontrib.spelling and hunspell

@matrixise
Copy link
Member Author

@ned-deily if you want, I can do the PR for 3.7 & 3.6, just keep me informed and I will work on it asap.

@JulienPalard JulienPalard merged commit 683281f into python:master Oct 6, 2018
@terryjreedy
Copy link
Member

Please go ahead with backports. I would first try using cherry_picker to make a 3.7 patch to see how many merge conflicts need to be resolved. For 3.6, I believe I would try cherry-picking the 3.7 patch, as the 3.6 subset will be a subset of the 3.7 subset. (This is not the usual procedure.)

@terryjreedy
Copy link
Member

Ste'phane, are you planning to backport? If not, I will do so for a couple of IDLE changes.

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 9, 2018
Fix typos

(cherry picked from commit 683281f)
matrixise added a commit to matrixise/cpython that referenced this pull request Oct 9, 2018
matrixise added a commit to matrixise/cpython that referenced this pull request Oct 10, 2018
matrixise added a commit to matrixise/cpython that referenced this pull request Oct 10, 2018
JulienPalard pushed a commit that referenced this pull request Oct 10, 2018
JulienPalard pushed a commit that referenced this pull request Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants