New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34906: Doc: Fix typos (2) #9735

Merged
merged 3 commits into from Oct 6, 2018

Conversation

Projects
None yet
7 participants
@matrixise
Contributor

matrixise commented Oct 5, 2018

Second turn for the typo in the doc, mainly for the Misc/ directory

https://bugs.python.org/issue34906

@ned-deily

LGTM. You'll probably need to make a manual backport to 3.7 and 3.6 of the subsets that apply to each.

Show resolved Hide resolved Misc/HISTORY
@terryjreedy

The idlelib corrections will backport cleanly.

@matrixise

This comment has been minimized.

Contributor

matrixise commented Oct 6, 2018

@vadmium here is my patch for mailformed thank you.

@matrixise

This comment has been minimized.

Contributor

matrixise commented Oct 6, 2018

For this PR and the previous one, I used sphinxcontrib.spelling and hunspell

@matrixise

This comment has been minimized.

Contributor

matrixise commented Oct 6, 2018

@ned-deily if you want, I can do the PR for 3.7 & 3.6, just keep me informed and I will work on it asap.

@JulienPalard JulienPalard merged commit 683281f into python:master Oct 6, 2018

5 checks passed

Azure Pipelines PR #20181006.17 succeeded
Details
bedevere/issue-number Issue number 34906 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@terryjreedy

This comment has been minimized.

Member

terryjreedy commented Oct 6, 2018

Please go ahead with backports. I would first try using cherry_picker to make a 3.7 patch to see how many merge conflicts need to be resolved. For 3.6, I believe I would try cherry-picking the 3.7 patch, as the 3.6 subset will be a subset of the 3.7 subset. (This is not the usual procedure.)

@terryjreedy

This comment has been minimized.

Member

terryjreedy commented Oct 9, 2018

Ste'phane, are you planning to backport? If not, I will do so for a couple of IDLE changes.

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 9, 2018

bpo-34906: Doc: Fix typos (2) (pythonGH-9735)
Fix typos

(cherry picked from commit 683281f)

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 9, 2018

bpo-34906: Doc: Fix typos (2) (pythonGH-9735)
Fix typos

(cherry picked from commit 683281f)

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 9, 2018

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 10, 2018

matrixise added a commit to matrixise/cpython that referenced this pull request Oct 10, 2018

JulienPalard added a commit that referenced this pull request Oct 10, 2018

[3.7] bpo-34906: Doc: Fix typos (2) (GH-9735)
(cherry picked from commit 683281f)

JulienPalard added a commit that referenced this pull request Oct 10, 2018

[3.6] bpo-34906: Doc: Fix typos (2) (GH-9735)
(cherry picked from commit 683281f)

yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment