/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-23596: Add unit tests for the command line for the gzip module #9775

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Reviewers

@JulienPalard JulienPalard

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@matrixise @bedevere-bot @miss-islington @JulienPalard @the-knights-who-say-ni
@matrixise
Contributor

matrixise commented Oct 9, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue23596

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 9, 2018

@bedevere-bot bedevere-bot added type-tests awaiting review labels Oct 9, 2018

@JulienPalard

JulienPalard requested changes Oct 9, 2018
View changes

Thanks for the PR @matrixise

Lib/test/test_gzip.py Outdated
out, err = proc.communicate(bytes_io.getvalue())
self.assertEqual(err, b'')
self.assertNotEqual(out, b'')

This comment has been minimized.

Sign in to view
Copy link
@JulienPalard

JulienPalard Oct 9, 2018

Member

Why not an assertEqual(out, self.data)?
Lib/test/test_gzip.py Outdated
out, err = proc.communicate(self.data)
self.assertEqual(err, b'')
self.assertNotEqual(out, b'')

This comment has been minimized.

Sign in to view
Copy link
@JulienPalard

JulienPalard Oct 9, 2018

Member

Why not self.assertEqual(out[:2], b"\x1f\x8b") (the gzip identification bytes)?
Show resolved Hide resolved Lib/test/test_gzip.py
Lib/test/test_gzip.py Outdated
def test_decompress_infile_outfile_error(self):
rc, out, err = assert_python_ok('-m', 'gzip', '-d', 'thisisatest.out')
self.assertTrue(out.startswith(b"filename doesn't end in .gz:"))

This comment has been minimized.

Sign in to view
Copy link
@JulienPalard

JulienPalard Oct 9, 2018

Member

Works, but what about an self.assertIn(b"filename doesn't end in .gz:", out)? Would probably produce a better error message, but does not check if the error is at the begining of the line.

@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Oct 9, 2018

@bedevere-bot

This comment has been minimized.

Sign in to view

bedevere-bot commented Oct 9, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JulienPalard JulienPalard added the skip news label Oct 9, 2018

@JulienPalard

JulienPalard approved these changes Oct 9, 2018
View changes

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Oct 9, 2018

@JulienPalard JulienPalard added needs backport to 3.6 needs backport to 3.7 labels Oct 9, 2018

@JulienPalard JulienPalard merged commit 84eec11 into python:master Oct 9, 2018
5 checks passed

5 checks passed

Azure Pipelines PR #20181009.36 succeeded
Details
bedevere/issue-number Issue number 23596 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view

miss-islington commented Oct 9, 2018

Thanks @matrixise for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Oct 9, 2018

miss-islington added a commit to miss-islington/cpython that referenced this pull request Oct 9, 2018

@matrixise @miss-islington
bpo-23596: Add unit tests for the command line for the gzip module (p… 
…ythonGH-9775)

Add unit tests for the command line for the gzip module
(cherry picked from commit 84eec11)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
99489e8
@bedevere-bot

This comment has been minimized.

Sign in to view

bedevere-bot commented Oct 9, 2018

GH-9779 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Oct 9, 2018

miss-islington added a commit to miss-islington/cpython that referenced this pull request Oct 9, 2018

@matrixise @miss-islington
bpo-23596: Add unit tests for the command line for the gzip module (p… 
…ythonGH-9775)

Add unit tests for the command line for the gzip module
(cherry picked from commit 84eec11)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
6a66fe3

@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Oct 9, 2018

@bedevere-bot

This comment has been minimized.

Sign in to view

bedevere-bot commented Oct 9, 2018

GH-9780 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Oct 9, 2018

@miss-islington @matrixise
bpo-23596: Add unit tests for the command line for the gzip module (G… 
…H-9775)

Add unit tests for the command line for the gzip module
(cherry picked from commit 84eec11)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
482dc94

miss-islington added a commit that referenced this pull request Oct 9, 2018

@miss-islington @matrixise
bpo-23596: Add unit tests for the command line for the gzip module (G… 
…H-9775)

Add unit tests for the command line for the gzip module
(cherry picked from commit 84eec11)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e23ba0

yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018

@matrixise @yahya-abou-imran
bpo-23596: Add unit tests for the command line for the gzip module (p… 
…ythonGH-9775)

Add unit tests for the command line for the gzip module
14ba974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment