Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Deploy pull request changes to Netlify so we can preview the devguide #463
Original thread in core-workflow mailing list:
It would be great if we can have a preview of the docs on the internet (without having to manually build it ourselves locally). This is useful for reviewers who want to view the changed documentation.
Service like netlify allows us to deploy the pull request changes for preview.
Before integrating this for docs.python.org, it would be great to try this out in devguide.
GitMate.io thinks possibly related issues are #133 (Update Devguide about pull request commit documentation.), #104 (Should an issue be created first, before the Pull Request?), #215 (Editing pull request: Can we rebase instead of merge?), #325 (Add tricks for the Pull Requests review?), and python/core-workflow#39 (checking code style for pull request).
I think I got it setup?
But I had signed up using a personal account on netlify. Perhaps I should transfer this to you or to the PSF?
I went to netlify, and added python/devguide repo.
I think that's all.
Under Build & deploy > Continuous Deployment > Deploy contexts, just ensure the Deploy previews: "Automatically build deploy previews for all pull requests" is selected (I think it was by default)