-
-
Notifications
You must be signed in to change notification settings - Fork 943
Remove some Misc/ACKS mentions
#1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Nov 25, 2025
Member
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update .github/CONTRIBUTING.md and replace:
The key points of
our workflow that are not covered by a bot or status check are:
- All discussions that are not directly related to the code in the pull request
should happen on the [issue tracker](https://devguide.python.org/tracker/)
- Upon your first non-trivial pull request (which includes documentation changes),
feel free to add yourself to [`Misc/ACKS`](https://github.com/python/cpython/blob/main/Misc/ACKS)With:
A key point of
our workflow that is not covered by a bot or status check is that all
discussions that are not directly related to the code in the pull request
should happen on the [issue tracker](https://devguide.python.org/tracker/).
ezio-melotti
approved these changes
Nov 25, 2025
AA-Turner
reviewed
Nov 25, 2025
AA-Turner
reviewed
Nov 25, 2025
AA-Turner
approved these changes
Nov 25, 2025
Member
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions:
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in the Discord, it seems this has widespread support.