New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename slave to worker #291

Merged
merged 9 commits into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@levlaz
Contributor

levlaz commented Nov 1, 2017

This PR renames all references from "slave" to "worker".

It fixes all broken URLs related to buildbot.

In addition, I added:

linkcheck_anchors_ignore = [
    # match any anchor that starts with a '/' since this is an invalid HTML anchor
    '\/.*',
]

to the conf.py file. The link checker was complaining that things like /console were invalid anchors. This is true since these are dynamically generated and not valid HTML anchors.

fix #290

Show outdated Hide outdated buildworker.rst Outdated
@zware

Looking good, but a few comments:

Show outdated Hide outdated buildbots.rst Outdated
Show outdated Hide outdated buildworker.rst Outdated
Show outdated Hide outdated buildworker.rst Outdated
Show outdated Hide outdated buildworker.rst Outdated
@@ -82,40 +82,40 @@ For Mac:
* Log in as the buildbot user.
* Install either the Python 2.7 bundle from python.org [#]_, or pip.
* Open a terminal window.
* Execute ``pip install buildbot-slave``.
* Execute ``pip install buildbot-worker``.
For Windows:
* Create a buildbot user as a "standard" user.
* Install the latest version of Python 2.7 from python.org.

This comment has been minimized.

@zware

zware Nov 1, 2017

Member

This no longer needs to specify 2.7; we can use any version we want now :)

@zware

zware Nov 1, 2017

Member

This no longer needs to specify 2.7; we can use any version we want now :)

This comment has been minimized.

@levlaz

levlaz Nov 2, 2017

Contributor

This series of instructions was a tad bit confusing so I specified that the last step is only necessary if using pip.

@levlaz

levlaz Nov 2, 2017

Contributor

This series of instructions was a tad bit confusing so I specified that the last step is only necessary if using pip.

This comment has been minimized.

@zware

zware Nov 9, 2017

Member

I'm a little lost on your comment here. My comment was just that we can remove "2.7" from this line :)

@zware

zware Nov 9, 2017

Member

I'm a little lost on your comment here. My comment was just that we can remove "2.7" from this line :)

Show outdated Hide outdated buildworker.rst Outdated
Show outdated Hide outdated buildworker.rst Outdated
Show outdated Hide outdated buildworker.rst Outdated
@levlaz

This comment has been minimized.

Show comment
Hide comment
@levlaz

levlaz Nov 2, 2017

Contributor

Thank you for the thorough review @zware. I made all the requested changes and used my best judgement when switching between "buildbot worker" and "worker".

Contributor

levlaz commented Nov 2, 2017

Thank you for the thorough review @zware. I made all the requested changes and used my best judgement when switching between "buildbot worker" and "worker".

Show outdated Hide outdated buildworker.rst Outdated
linkcheck_anchors_ignore = [
# match any anchor that starts with a '/' since this is an invalid HTML anchor
'\/.*',
]

This comment has been minimized.

@ezio-melotti

ezio-melotti Nov 2, 2017

Member

Missing newline at the end of the file.

@ezio-melotti

ezio-melotti Nov 2, 2017

Member

Missing newline at the end of the file.

This comment has been minimized.

@levlaz

levlaz Nov 2, 2017

Contributor

Ugh, even my linter yelled at me and I ignored it. Thank you :)

@levlaz

levlaz Nov 2, 2017

Contributor

Ugh, even my linter yelled at me and I ignored it. Thank you :)

@levlaz

This comment has been minimized.

Show comment
Hide comment
@levlaz

levlaz Nov 9, 2017

Contributor

Hey @zware I made all of the changes that you requested. Is there anything else I can do for this PR?

Contributor

levlaz commented Nov 9, 2017

Hey @zware I made all of the changes that you requested. Is there anything else I can do for this PR?

@zware

Just a couple of minor fixes to go :)

Show outdated Hide outdated buildworker.rst Outdated
@@ -82,40 +82,40 @@ For Mac:
* Log in as the buildbot user.
* Install either the Python 2.7 bundle from python.org [#]_, or pip.
* Open a terminal window.
* Execute ``pip install buildbot-slave``.
* Execute ``pip install buildbot-worker``.
For Windows:
* Create a buildbot user as a "standard" user.
* Install the latest version of Python 2.7 from python.org.

This comment has been minimized.

@zware

zware Nov 9, 2017

Member

I'm a little lost on your comment here. My comment was just that we can remove "2.7" from this line :)

@zware

zware Nov 9, 2017

Member

I'm a little lost on your comment here. My comment was just that we can remove "2.7" from this line :)

@levlaz

This comment has been minimized.

Show comment
Hide comment
@levlaz

levlaz Nov 9, 2017

Contributor

Thank you @zware! I think we are all set. Just pushed a change which makes the MacOS section (hopefully) crystal clear.

Contributor

levlaz commented Nov 9, 2017

Thank you @zware! I think we are all set. Just pushed a change which makes the MacOS section (hopefully) crystal clear.

@zware

zware approved these changes Nov 9, 2017

@zware zware merged commit 766ccd6 into python:master Nov 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment