New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automerge if there is "DO-NOT-MERGE" label and "CLA not signed" label #152

Merged
merged 4 commits into from Sep 12, 2018

Conversation

Projects
None yet
5 participants
@Mariatta
Member

Mariatta commented Sep 12, 2018

No description provided.

Mariatta added some commits Sep 12, 2018

@miss-islington

This comment has been minimized.

Collaborator

miss-islington commented Sep 12, 2018

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • miss_islington/util.py
  • tests/test_status_change.py
  • tests/test_util.py
    (I'm a bot 🤖)
@zware

zware approved these changes Sep 12, 2018

LGTM!

@codecov

This comment has been minimized.

codecov bot commented Sep 12, 2018

Codecov Report

Merging #152 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #152      +/-   ##
=========================================
+ Coverage   96.14%   96.3%   +0.15%     
=========================================
  Files           9       9              
  Lines         727     757      +30     
  Branches       48      48              
=========================================
+ Hits          699     729      +30     
  Misses         28      28
Impacted Files Coverage Δ
tests/test_util.py 100% <100%> (ø) ⬆️
tests/test_status_change.py 100% <100%> (ø) ⬆️
miss_islington/util.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c607cce...01f7fd5. Read the comment docs.

@mariatta-bot

This comment has been minimized.

mariatta-bot commented Sep 12, 2018

Mariatta was mentioned, but she's out of open source for the rest of September 2018. Be aware she might not get to this until October 2018.
(I'm a bot)

Mariatta added some commits Sep 12, 2018

@Mariatta Mariatta added the black out label Sep 12, 2018

@miss-islington

This comment has been minimized.

Collaborator

miss-islington commented Sep 12, 2018

🐍🌚🤖 PR is already black! Good job!

@zware

zware approved these changes Sep 12, 2018

@Mariatta Mariatta merged commit 15c47c8 into python:master Sep 12, 2018

3 checks passed

codecov/patch 100% of diff hit (target 96.14%)
Details
codecov/project 96.3% (+0.15%) compared to c607cce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mariatta Mariatta deleted the Mariatta:consider-do-not-merge branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment