New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the PR with one core dev approval and CI passed. #51

Merged
merged 3 commits into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@Mariatta
Copy link
Member

Mariatta commented Feb 12, 2018

Allow miss-islington to merge the PR if all of these conditions met:

  • All CI passed
  • At least one core dev approved
  • PR is made by miss-islington

Closes #44

Mariatta added some commits Feb 12, 2018

Merge the PR with one core dev approval and CI passed.
Allow miss-islington to merge the PR if all of these conditions met:
- All CI passed
- At least one core dev approved
- PR is made by miss-islington
eol

@Mariatta Mariatta merged commit 69f93c6 into python:master Feb 12, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@Mariatta Mariatta deleted the Mariatta:improve branch Feb 12, 2018

@terryjreedy

This comment has been minimized.

Copy link
Member

terryjreedy commented Feb 12, 2018

HOO-RAY! Automerge worked great for python/cpython#5639.
About to repeat with another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment