New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn-unused-ignores does not respect follow-imports=silent #3949

Closed
carljm opened this Issue Sep 12, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@carljm
Contributor

carljm commented Sep 12, 2017

$ cat imported.py
a: int = 'foo'

b: int = 3  # type: ignore

$ cat main.py 
import imported

$ mypy --warn-unused-ignores --follow-imports=silent main.py
imported.py:3: note: unused 'type: ignore' comment

follow-imports=silent correctly silences the type error on line 1 of imported.py, but fails to silence the "unused type: ignore comment" note.

@ethanhs ethanhs added the bug label Sep 12, 2017

@ethanhs

This comment has been minimized.

Collaborator

ethanhs commented Sep 12, 2017

Confirmed on master. Thank you for the small and simple repro!

msullivan added a commit that referenced this issue Apr 4, 2018

msullivan added a commit that referenced this issue Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment