Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
"Could not find builtins" error #915
With the latest dev version of mypy (currently 47b40a7) - since my most recent git pull, I get this error when trying to run mypy:
test.py:1: error: Could not find builtins
Where this is the complete contents of test.py:
And the command-line is:
(Where I am under a Python virtualenv, where the latest dev version of mypy has been installed).
I ran a git bisect to track down where this issue started, and ended up at this commit where - in my testing - this problem starts manifesting:
This is a breaking issue for me - for now I need to do my dev/testing against the commit prior to that, 2e591dc, where the problem has not yet manifested.
referenced this issue
Oct 13, 2015
@o11c: I did not reject your fix, I asked you to resend it with unrelated changes removed and with an explanation of how the fix works. You did not wish to do this but started complaining publicly, so I had to fix it myself. Emergency fixes should be short and to the point. Time and time again a rushed fix has introduced additional problems (see http://www.infoworld.com/article/2608134/microsoft-windows/the-new-kb-2919355-windows-8-1-update-causes-more-problems-than-it-fixes.html for example).
The new test runner moved most of the logic from
@o11c: I've previously said that I prefer getting PRs with a single logical change instead of large PRs with multiple, unrelated changes. From now on I'll take a firmer stand and ask you to split all PRs into cohesive units. Also, I'm the BDFL of this project (or at least BDForNow) and it would be much easier for you to follow the guidelines that I set (which are similar for all contributors, except for new contributors who get some slack) instead of constantly bickering about me asking you to follow rules that you don't agree with. If you don't like a rule or if the guidelines are not explicit enough you can open an issue for discussing whether that should be changed, but please be civil. I may have to create a code for conduct for this project, but hopefully I don't have to go that far.
@o11c: And yes, I did not quite understand your patch, but I asked for clarification. Is this going to be some sort of guess-what-my-patch does mystery game? Not understanding something is totally fine in this project, and I hope that everybody who contributes acknowledges that we are all human and sometimes need help. Ridiculing others for having trouble with something is totally not cool.
You have a very strange sense of "unrelated changes", and some disturbing lacks of knowledge about your own project and the language you are using to write it.
And you don't have to worry about me splitting PRs, I won't be making any more. Rather, I will encourage people to submit their PRs directly to my repo, since most people seem to have a significantly different idea of it than you.
To you, mypy is still your toy little project. But since PEP 484 landed, that's no longer what it is, and you can't afford to keep thinking of it that way.
Oct 13, 2015
@o11c: I've blocked you for now, as I'm tired of you not being respectful. I'll add some instructions on how to unblock yourself if you want to work on your behavior (they will be added to http://www.mypy-lang.org/wiki/DeveloperGuides). The mypy repo has become a toxic place for me to work in (and probably others) recently. It should be a fun, friendly and co-operative environment.
everybody: Apologies for everybody affected -- I should have been more proactive and not have waited until things escalate this far. Feel free to email me if you want to understand the background a little better or have any concerns, or open issues to discuss what is acceptable behavior. This has been an isolated incident and almost everybody has been wonderful.