Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyopenssl types package corrected #10656

Merged
merged 1 commit into from Jun 16, 2021
Merged

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Jun 16, 2021

pyopenssl's types package name was corrected in typeshed. It's now also available for Python 3.

It's now also available for Python 3
@github-actions
Copy link

github-actions bot commented Jun 16, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

scrapy (https://github.com/scrapy/scrapy.git)
+ scrapy/utils/ssl.py:1: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/utils/ssl.py:2: error: Library stubs not installed for "OpenSSL._util" (or incompatible with Python 3.8)
+ scrapy/core/downloader/tls.py:3: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/core/downloader/contextfactory.py:3: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/core/downloader/contextfactory.py:3: note: Hint: "python3 -m pip install types-pyOpenSSL"
+ scrapy/core/downloader/contextfactory.py:3: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/core/downloader/contextfactory.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- scrapy/cmdline.py:6: note: (or run "mypy --install-types" to install all missing stub packages)
- scrapy/cmdline.py:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ tests/mockserver.py:12: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ tests/test_webclient.py:11: error: Library stubs not installed for "OpenSSL.SSL" (or incompatible with Python 3.8)
+ tests/test_webclient.py:11: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)

@JelleZijlstra JelleZijlstra merged commit d87d468 into python:master Jun 16, 2021
6 checks passed
@srittau srittau deleted the types-pyopenssl branch Jun 16, 2021
@JukkaL JukkaL mentioned this pull request Jun 17, 2021
JukkaL pushed a commit that referenced this pull request Jun 21, 2021
It's now also available for Python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants