Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask to install a stub package if stubs are installed #10670

Merged
merged 3 commits into from Jun 22, 2021

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 18, 2021

If we encounter an import of a submodule of a package with installed
stubs, and the submodule doesn't exist, don't ask to install stubs
since that's not going to help. Also make it possible to ignore this
error using --ignore-missing-imports.

Work on #10645.

JukkaL added 2 commits Jun 18, 2021
If we encounter an import of a submodule of a package with installed
stubs, and the submodule doesn't exist, don't ask to install stubs
since that's not going to help. Also make it possible to ignore this
error using `--ignore-missing-imports`.

Work on #10645.
@github-actions

This comment has been minimized.

@JukkaL JukkaL merged commit 002722e into master Jun 22, 2021
6 checks passed
@JukkaL JukkaL deleted the fix-ignore-missing-imports branch Jun 22, 2021
JukkaL added a commit that referenced this pull request Jun 22, 2021
If we encounter an import of a submodule of a package with installed
stubs, and the submodule doesn't exist, don't ask to install stubs
since that's not going to help. Also make it possible to ignore this
error using `--ignore-missing-imports`.

Work on #10645.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants