Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_simplified_union: simpler and faster #12630

Merged
merged 2 commits into from Apr 20, 2022
Merged

Conversation

huguesb
Copy link
Contributor

@huguesb huguesb commented Apr 20, 2022

Recent attempts at speedup introduced some convoluted logic that both
reduced accuracy and caused performance regressions. Fix this and add
more comments to clarify the reasoning behind the optimization.

Recent attempts at speedup introduced some convoluted logic that both
reduced accuracy and caused performance regressions. Fix this and add
more comments to clarify the reasoning behind the optimization.
@huguesb huguesb mentioned this pull request Apr 20, 2022
@github-actions

This comment has been minimized.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Thanks, looks good to me, this is a nice change.

I think is_likely_literal_supertype should be unused now — could you remove it?

@huguesb
Copy link
Contributor Author

@huguesb huguesb commented Apr 20, 2022

I think is_likely_literal_supertype should be unused now — could you remove it?

done

@github-actions
Copy link

@github-actions github-actions bot commented Apr 20, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Apr 20, 2022

Thanks! This is much cleaner than what we had before.

@JukkaL JukkaL merged commit 8b1a810 into python:master Apr 20, 2022
15 checks passed
JukkaL pushed a commit that referenced this issue Apr 20, 2022
Recent attempts at speedup introduced some convoluted logic that both
reduced accuracy and caused performance regressions. Fix this and add
more comments to clarify the reasoning behind the optimization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants