Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] Fix glue methods with native int types #13939

Merged
merged 8 commits into from Oct 25, 2022
Merged

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Oct 23, 2022

This fixes handling of bitmap arguments used to track default values of arguments with native int types in method overrides.

The main use case is a method override that adds a native int argument with a default value to the base class signature.

Also generate an error if we don't support generating a glue method for an override. This can happen if the positions of bits in the bitmap would change in the subclass. We also don't support switching between error values and default value bitmaps in glue methods. These could be supported, but it would be complicated and doesn't seem worth it.

Work on mypyc/mypyc#837.

@JukkaL JukkaL merged commit ec149da into master Oct 25, 2022
12 checks passed
@JukkaL JukkaL deleted the native-int-glue-3 branch Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants