Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TryStar not crash #13991

Merged
merged 3 commits into from Nov 3, 2022
Merged

Make TryStar not crash #13991

merged 3 commits into from Nov 3, 2022

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Nov 2, 2022

cc @svalentin @JukkaL This is probably mostly correct, but I haven't thought about it super hard. Definitely should stop crashes!

@github-actions

This comment has been minimized.

@svalentin
Copy link
Collaborator

I think as long as it's not crashing it should be fine. But will let @JukkaL take a closer look.

That said, a test is failing. I think we have some an incorrect py311 check.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Nov 2, 2022

Found something that needed to be changed, but weird that it worked locally for me (oh figured it out, I had an RC build of 3.11 which missed python/cpython#96588)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja
Copy link
Collaborator Author

Going to go ahead and merge + backport since it fixes the crash and doesn't behave entirely terribly. Ivan said he would look into actual support.

@hauntsaninja hauntsaninja merged commit 0457d33 into python:master Nov 3, 2022
17 checks passed
@hauntsaninja hauntsaninja deleted the trystar branch Nov 3, 2022
hauntsaninja added a commit that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants