Skip to content

Add missing TypedDict special case to checkmember.py - #18604

Merged
hauntsaninja merged 1 commit into
python:masterfrom
sterliakov:bugfix/st-typeddict-lost-when-inherited
Feb 5, 2025
Merged

Add missing TypedDict special case to checkmember.py#18604
hauntsaninja merged 1 commit into
python:masterfrom
sterliakov:bugfix/st-typeddict-lost-when-inherited

Conversation

@sterliakov

Copy link
Copy Markdown
Collaborator

Fixes #18600.

@github-actions

This comment has been minimized.

@sterliakov
sterliakov force-pushed the bugfix/st-typeddict-lost-when-inherited branch from 1039040 to 8de88f2 Compare February 5, 2025 02:14
@sterliakov
sterliakov marked this pull request as ready for review February 5, 2025 02:22
@github-actions

github-actions Bot commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!

@hauntsaninja
hauntsaninja merged commit 6f32ef9 into python:master Feb 5, 2025
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypedDict arguments are not recognized if a base class's nested class is accessed via a subclass

2 participants