Skip to content

[mypyc] Optimize str.__contains__ - #18705

Merged
JukkaL merged 2 commits into
python:masterfrom
cdce8p:mypyc-str-contains
Feb 19, 2025
Merged

[mypyc] Optimize str.__contains__#18705
JukkaL merged 2 commits into
python:masterfrom
cdce8p:mypyc-str-contains

Conversation

@cdce8p

@cdce8p cdce8p commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

@cdce8p cdce8p added the topic-mypyc mypyc bugs label Feb 18, 2025

@JukkaL JukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a few minor comments only. Interestingly, the C API docs say "substr has to coerce to a one element Unicode string", but it doesn't seem to be true (link).

Comment thread mypyc/test-data/run-strings.test
Comment thread mypyc/primitives/str_ops.py Outdated
@JukkaL
JukkaL merged commit 49e014a into python:master Feb 19, 2025
@cdce8p
cdce8p deleted the mypyc-str-contains branch February 19, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-mypyc mypyc bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants