Repository navigation
[mypyc] feat: exact_dict_set_item_op - #19657
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
…r/mypy into exact-dict-set-item
JukkaL
reviewed
Aug 14, 2025
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for splitting the original big PR. Looks good, just a few style things.
Contributor
Author
|
Thanks for your feedbacks, I've resolved both. |
JukkaL
approved these changes
Aug 14, 2025
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick updates, looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a
exact_dict_set_item_opcustom_op in preparation for the addition of exact_dict_rprimitive. We don't actually need to implement exact_dict_rprimitive before implementing this op as long as we accept that it will not be used for CallExpr specialization. This is okay for us now, as it is already addressed in the larger PR.