Skip to content

Avoid errors in select() calls in stdlib-samples. #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Avoid errors in select() calls in stdlib-samples. #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-data/stdlib-samples/3.2/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,7 @@ def _communicate_with_select(self, input: Any) -> Tuple[List[bytes],
input_offset = 0
while read_set or write_set:
try:
rlist, wlist, xlist = select.select(read_set, write_set, [])
rlist, wlist, xlist = select.select(read_set, write_set, cast(List[object], []))
except select.error as e:
if e.args[0] == errno.EINTR:
continue
Expand Down
2 changes: 1 addition & 1 deletion test-data/stdlib-samples/3.2/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,7 @@ def kill_p2() -> None:
p1.stdin.write(data)
p1.stdin.close()

readfiles, ignored1, ignored2 = select.select([p2.stdout], [], [], 10)
readfiles, ignored1, ignored2 = select.select([p2.stdout], cast(List[object], []), cast(List[object], []), 10)

self.assertTrue(readfiles, "The child hung")
self.assertEqual(p2.stdout.read(), data)
Expand Down